Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed action to copy Service Dialog #16623

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Renamed action to copy Service Dialog #16623

merged 1 commit into from
Jan 4, 2018

Conversation

romanblanco
Copy link
Member

@romanblanco romanblanco mentioned this pull request Dec 8, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Dec 8, 2017

Checked commit romanblanco@1f460c4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@himdel
Copy link
Contributor

himdel commented Jan 4, 2018

LGTM :)

@miq-bot assign martinpovolny

@romanblanco
Copy link
Member Author

ping @martinpovolny, can you merge, please?

@dclarizio dclarizio merged commit d2e5a32 into ManageIQ:master Jan 4, 2018
@dclarizio dclarizio added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 4, 2018
@romanblanco romanblanco deleted the bz1518918 branch January 4, 2018 16:53
simaishi pushed a commit that referenced this pull request Jan 4, 2018
@simaishi
Merge pull request #16623 from romanblanco/bz1518918
023c007 
Renamed action to copy Service Dialog
(cherry picked from commit d2e5a32)

https://bugzilla.redhat.com/show_bug.cgi?id=1531297
@simaishi
Copy link
Contributor

simaishi commented Jan 4, 2018

Gaprindashvili backport details:

$ git log -1
commit 023c007e4be2e34ec58e4c37d122b75741c13ac7
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Thu Jan 4 08:30:54 2018 -0800

    Merge pull request #16623 from romanblanco/bz1518918
    
    Renamed action to copy Service Dialog
    (cherry picked from commit d2e5a326cb06f0fadf2e3800cc14a38af45af6a6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531297

imtayadeway added a commit to imtayadeway/manageiq-api that referenced this pull request Jan 5, 2018
@imtayadeway
Update dialog copy product feature
a499e85 
1f460c4628a4dcac0803e306c31d63c2055934e7 in the main repository
changed the name of this product feature, breaking the contract
between product features and the API. This PR updates the API to be
back in sync.

Links: ManageIQ/manageiq#16623
@imtayadeway imtayadeway mentioned this pull request Jan 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug gaprindashvili/backported ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@romanblanco @miq-bot @himdel @simaishi @martinpovolny @dclarizio